[asterisk-dev] [Code Review] 2812: Testsuite: Fix intermittent bridge test failures

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2812/#review9596
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Aug. 30, 2013, 7:09 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2812/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 7:09 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and rmudgett.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Prior to this patch, bridge tests (I'm thinking all of them now) would fail intermittently in 12/trunk due to possible variance in entry order when it comes to receiving bridge entry events. This test module was written with the assumption that Alice would always enter first while testing revealed that it was possible (though slightly rare) for Bob to enter first. According to Richard, entry order one way or another is not guaranteed.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 4081 
> 
> Diff: https://reviewboard.asterisk.org/r/2812/diff/
> 
> 
> Testing
> -------
> 
> Prior to patch:
>    Ran bridge/parkcall_blindxfer test 25 times (test involves 5 separate call scenarios, so basically this is 125 tests against bridge_enter)
>    Test failed 6 of the 25 times, each time due to Bob entering first.
> 
> Post patch:
>    Ran bridge/parkcall_blindxfer test 25 times
>    Test didn't fail ever.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130905/396e32d9/attachment.htm>