[asterisk-dev] [Code Review] 2823: Documentation fix and improvements to XML configuration help res_pjsip_acl

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2823/#review9590
-----------------------------------------------------------



/branches/12/res/res_pjsip_acl.c
<https://reviewboard.asterisk.org/r/2823/#comment18770>

    I suggest clarifying that the contact variations of the ACL options only apply to incoming REGISTER requests.
    
    "... or the contactpermit and contactdeny options which act on Contact header addresses in incoming REGISTER requests."
    
    As long as the distinction is made here, it doesn't need to be reiterated in the explanations of the individual configOptions



/branches/12/res/res_pjsip_acl.c
<https://reviewboard.asterisk.org/r/2823/#comment18771>

    The wording of the second sentence is a bit strange.
    
    "IP addresses may have a subnet mask appended. The subnet mask may be written in either CIDR or dotted-decimal notation. Separate the IP address and subnet mask with a slash ('/')"


- Mark Michelson


On Sept. 4, 2013, 7:59 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2823/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 7:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22458
>     https://issues.asterisk.org/jira/browse/ASTERISK-22458
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> One bug fix. The synopsis for "type" was wrong.
> 
> When Mark and I were looking at some ACL issue we noted that there should be some improvements to the documentation.
> 
> Notably:
> 
>  *  changing the usage of "IP-domains" to "IP addresses"
>  *  clarifying the usage for the options, by adding a relevant description for each
>  *  modified other areas of the XML help for clarity, such as the module description and a few synopsis changes here and there. See the patch.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_acl.c 398277 
> 
> Diff: https://reviewboard.asterisk.org/r/2823/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130904/f17240c3/attachment.htm>