[asterisk-dev] [Code Review] Pimp SIP Location

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2379/
-----------------------------------------------------------

(Updated March 11, 2013, 11:47 a.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Incorporated feedback from Mark.


Summary
-------

Knowing where something is and how to dial it is quite important, so these changes implement the following to accomplish that:

1. A low level API is now provided for location. It's a thin wrapper over sorcery allowing retrieval, creating, updating, and deleting of AORs/contacts. It also allows explicit contacts to be configured on the AOR itself.
2. A dialplan function (GULP_DIAL_CONTACTS) is now provided which creates a dial string capable of dialing all contacts on an AOR.
3. Dialing an endpoint, AOR, or SIP URI is now possible in dial strings.
4. res_sip_endpoint_identifier_ip is now fully configurable and can match IP ranges as well as individual IPs.


Diffs (updated)
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 382784 
  /team/group/pimp_my_sip/include/asterisk/res_sip.h 382784 
  /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 382784 
  /team/group/pimp_my_sip/res/res_sip.c 382784 
  /team/group/pimp_my_sip/res/res_sip.exports.in 382784 
  /team/group/pimp_my_sip/res/res_sip/location.c PRE-CREATION 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 382784 
  /team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c 382784 
  /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 382784 
  /team/group/pimp_my_sip/res/res_sip_session.c 382784 

Diff: https://reviewboard.asterisk.org/r/2379/diff


Testing
-------

Tested outgoing calls galore in various combinations. Also tested incoming call matching with res_sip_endpoint_identifier_ip.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130311/e8b51073/attachment.htm>