<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2379/">https://reviewboard.asterisk.org/r/2379/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 11:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Incorporated feedback from Mark.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Knowing where something is and how to dial it is quite important, so these changes implement the following to accomplish that:
1. A low level API is now provided for location. It's a thin wrapper over sorcery allowing retrieval, creating, updating, and deleting of AORs/contacts. It also allows explicit contacts to be configured on the AOR itself.
2. A dialplan function (GULP_DIAL_CONTACTS) is now provided which creates a dial string capable of dialing all contacts on an AOR.
3. Dialing an endpoint, AOR, or SIP URI is now possible in dial strings.
4. res_sip_endpoint_identifier_ip is now fully configurable and can match IP ranges as well as individual IPs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested outgoing calls galore in various combinations. Also tested incoming call matching with res_sip_endpoint_identifier_ip.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/pimp_my_sip/channels/chan_gulp.c <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/include/asterisk/res_sip_session.h <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip.c <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip.exports.in <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip/location.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip_sdp_audio.c <span style="color: grey">(382784)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip_session.c <span style="color: grey">(382784)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2379/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>