[asterisk-dev] [Code Review] 2772: Bridge API: Set a cause code on a channel when it is ejected from a bridge.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2772/
-----------------------------------------------------------

(Updated Aug. 22, 2013, 5:54 p.m.)


Review request for Asterisk Developers.


Changes
-------

Freshen review and remove an associated BUGBUG comment I missed.


Bugs: ASTERISK-22042
    https://issues.asterisk.org/jira/browse/ASTERISK-22042


Repository: Asterisk


Description
-------

The cause code needs to be passed from the disconnecting channel to the bridge peers if the disconnecting channel dissolves the bridge.

* Made the call to an app_agent_pool agent disconnect with the busy cause code if the agent does not ack the call in time or hangs up before acking the call.


Diffs (updated)
-----

  /trunk/apps/app_agent_pool.c 397441 
  /trunk/apps/app_bridgewait.c 397441 
  /trunk/apps/app_confbridge.c 397441 
  /trunk/apps/app_dial.c 397441 
  /trunk/bridges/bridge_builtin_features.c 397441 
  /trunk/bridges/bridge_builtin_interval_features.c 397441 
  /trunk/include/asterisk/bridge.h 397441 
  /trunk/include/asterisk/bridge_channel.h 397441 
  /trunk/include/asterisk/bridge_internal.h 397441 
  /trunk/main/bridge.c 397441 
  /trunk/main/bridge_basic.c 397441 
  /trunk/main/bridge_channel.c 397441 
  /trunk/main/features.c 397441 
  /trunk/res/parking/parking_applications.c 397441 
  /trunk/res/parking/parking_bridge_features.c 397441 
  /trunk/res/res_parking.c 397441 
  /trunk/res/res_stasis.c 397441 

Diff: https://reviewboard.asterisk.org/r/2772/diff/


Testing
-------

* Disconnected a bridged call with a cause code that is not normal clearing.  Before the patch the peer channel reported normal clearing.  With the patch, the peer channel reports the cause code of the disconnected channel that dissolved the bridge.

* Calling channel to an agent now disconnects with the busy cause code if the agent either does not ack the call in time or hangs up before acking the call.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130822/3a129d4d/attachment-0001.htm>