<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2772/">https://reviewboard.asterisk.org/r/2772/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2013, 5:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Freshen review and remove an associated BUGBUG comment I missed.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22042">ASTERISK-22042</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The cause code needs to be passed from the disconnecting channel to the bridge peers if the disconnecting channel dissolves the bridge.
* Made the call to an app_agent_pool agent disconnect with the busy cause code if the agent does not ack the call in time or hangs up before acking the call.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Disconnected a bridged call with a cause code that is not normal clearing. Before the patch the peer channel reported normal clearing. With the patch, the peer channel reports the cause code of the disconnected channel that dissolved the bridge.
* Calling channel to an agent now disconnects with the busy cause code if the agent either does not ack the call in time or hangs up before acking the call.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_agent_pool.c <span style="color: grey">(397441)</span></li>
<li>/trunk/apps/app_bridgewait.c <span style="color: grey">(397441)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(397441)</span></li>
<li>/trunk/apps/app_dial.c <span style="color: grey">(397441)</span></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(397441)</span></li>
<li>/trunk/bridges/bridge_builtin_interval_features.c <span style="color: grey">(397441)</span></li>
<li>/trunk/include/asterisk/bridge.h <span style="color: grey">(397441)</span></li>
<li>/trunk/include/asterisk/bridge_channel.h <span style="color: grey">(397441)</span></li>
<li>/trunk/include/asterisk/bridge_internal.h <span style="color: grey">(397441)</span></li>
<li>/trunk/main/bridge.c <span style="color: grey">(397441)</span></li>
<li>/trunk/main/bridge_basic.c <span style="color: grey">(397441)</span></li>
<li>/trunk/main/bridge_channel.c <span style="color: grey">(397441)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(397441)</span></li>
<li>/trunk/res/parking/parking_applications.c <span style="color: grey">(397441)</span></li>
<li>/trunk/res/parking/parking_bridge_features.c <span style="color: grey">(397441)</span></li>
<li>/trunk/res/res_parking.c <span style="color: grey">(397441)</span></li>
<li>/trunk/res/res_stasis.c <span style="color: grey">(397441)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2772/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>