[asterisk-dev] [Code Review] 2781: config_options: Drop missing config file ERROR statement to a WARNING

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2781/#review9466
-----------------------------------------------------------


It depends.  If this is a module that was loaded through a load statement, then in most cases, not having a configuration file for that module really is an error.  I do see your point about the core, though.

Honestly, we should be calling ast_config_load2 here, and have the name of the calling module passed in, which would tell us whether we were called from the core or from a loaded module.  Then you could vary whether this is an error or a warning (or, really, even a NOTICE from the core) based upon that value.

- Tilghman Lesher


On Aug. 21, 2013, 7:42 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2781/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 7:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> One liner, but it is worth discussing.
> 
> Currently, if config_options doesn't detect a config file for a module, it emits an ERROR.
> 
> That seems a bit excessive, particularly for config files processed by the Asterisk core. It is not an error to be missing acl.conf - you just won't have ACLs. That feels like a WARNING at best to me.
> 
> Objections?
> 
> 
> Diffs
> -----
> 
>   /trunk/main/config_options.c 397306 
> 
> Diff: https://reviewboard.asterisk.org/r/2781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130821/f2f48fc7/attachment.htm>