<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2781/">https://reviewboard.asterisk.org/r/2781/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It depends. If this is a module that was loaded through a load statement, then in most cases, not having a configuration file for that module really is an error. I do see your point about the core, though.
Honestly, we should be calling ast_config_load2 here, and have the name of the calling module passed in, which would tell us whether we were called from the core or from a loaded module. Then you could vary whether this is an error or a warning (or, really, even a NOTICE from the core) based upon that value.</pre>
<br />
<p>- Tilghman</p>
<br />
<p>On August 21st, 2013, 7:42 p.m. UTC, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2013, 7:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One liner, but it is worth discussing.
Currently, if config_options doesn't detect a config file for a module, it emits an ERROR.
That seems a bit excessive, particularly for config files processed by the Asterisk core. It is not an error to be missing acl.conf - you just won't have ACLs. That feels like a WARNING at best to me.
Objections?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/config_options.c <span style="color: grey">(397306)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2781/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>