[asterisk-dev] [Code Review] 2763: Allow res_parking to be unloadable

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2763/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 9:38 p.m.)


Review request for Asterisk Developers and jrose.


Changes
-------

Address Richard's comments.


Bugs: ASTERISK-22142
    https://issues.asterisk.org/jira/browse/ASTERISK-22142


Repository: Asterisk


Description
-------

This change protects accesses of res_parking such that it can unload safely once transient uses of its registered functions are complete. It was necessary to add ref and unref callbacks to the parking vtable to let res_parking know when it was being used to prevent dangerous unloading.

This adds calls to all the parking unload functions and moves application loading and unloading into functions in parking_applications.c similar to the rest of the parts of res_parking.


Diffs (updated)
-----

  /trunk/include/asterisk/parking.h 396821 
  /trunk/main/bridge_channel.c 396821 
  /trunk/main/features.c 396821 
  /trunk/main/parking.c 396821 
  /trunk/res/parking/parking_applications.c 396821 
  /trunk/res/parking/parking_bridge_features.c 396821 
  /trunk/res/parking/parking_tests.c 396821 
  /trunk/res/parking/res_parking.h 396821 
  /trunk/res/res_parking.c 396821 

Diff: https://reviewboard.asterisk.org/r/2763/diff/


Testing
-------

Unloaded and reloaded res_parking ensuring that created dialplan was removed and that tests passed once reloaded.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130816/5151500a/attachment.htm>