[asterisk-dev] [Code Review] 2763: Allow res_parking to be unloadable

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2763/#review9414
-----------------------------------------------------------



/trunk/main/parking.c
<https://reviewboard.asterisk.org/r/2763/#comment18477>

    These are supposed to be both fn_table.parking_ref.



/trunk/res/res_parking.c
<https://reviewboard.asterisk.org/r/2763/#comment18478>

    This routine does not cleanup everything if there is an error.  It likely should just call unload_module().
    
    Not cleaning up will cause a failure to reload the module once the problem is corrected.


- rmudgett


On Aug. 15, 2013, 6:25 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2763/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 6:25 p.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Bugs: ASTERISK-22142
>     https://issues.asterisk.org/jira/browse/ASTERISK-22142
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change protects accesses of res_parking such that it can unload safely once transient uses of its registered functions are complete. It was necessary to add ref and unref callbacks to the parking vtable to let res_parking know when it was being used to prevent dangerous unloading.
> 
> This adds calls to all the parking unload functions and moves application loading and unloading into functions in parking_applications.c similar to the rest of the parts of res_parking.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/parking.h 396787 
>   /trunk/main/parking.c 396787 
>   /trunk/res/parking/parking_applications.c 396787 
>   /trunk/res/parking/parking_bridge_features.c 396787 
>   /trunk/res/parking/res_parking.h 396787 
>   /trunk/res/res_parking.c 396787 
> 
> Diff: https://reviewboard.asterisk.org/r/2763/diff/
> 
> 
> Testing
> -------
> 
> Unloaded and reloaded res_parking ensuring that created dialplan was removed and that tests passed once reloaded.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130815/2f20aaa6/attachment.htm>