[asterisk-dev] [Code Review] 2732: Refactor CEL to avoid using the event system as a distribution mechanism

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2732/#review9283
-----------------------------------------------------------



team/kmoore/event_system_strip/main/cel.c
<https://reviewboard.asterisk.org/r/2732/#comment18282>

    Stringfields are overkill here. 0 sized array it.



team/kmoore/event_system_strip/main/cel.c
<https://reviewboard.asterisk.org/r/2732/#comment18281>

    I just want to confirm that this runs in the same serialized fashion as the old code - I've read the code and think so, but confirmation is good.


- Joshua Colp


On Aug. 1, 2013, 12:28 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2732/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 12:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This removes usage of the event system for CEL backend data distribution and strips unused pieces out of the event system.
> 
> This build on the work in https://reviewboard.asterisk.org/r/2703/
> 
> 
> Diffs
> -----
> 
>   team/kmoore/event_system_strip/cel/cel_custom.c 395936 
>   team/kmoore/event_system_strip/cel/cel_manager.c 395936 
>   team/kmoore/event_system_strip/cel/cel_odbc.c 395936 
>   team/kmoore/event_system_strip/cel/cel_pgsql.c 395936 
>   team/kmoore/event_system_strip/cel/cel_radius.c 395936 
>   team/kmoore/event_system_strip/cel/cel_sqlite3_custom.c 395936 
>   team/kmoore/event_system_strip/cel/cel_tds.c 395936 
>   team/kmoore/event_system_strip/include/asterisk/_private.h 395936 
>   team/kmoore/event_system_strip/include/asterisk/cel.h 395936 
>   team/kmoore/event_system_strip/include/asterisk/event.h 395936 
>   team/kmoore/event_system_strip/include/asterisk/event_defs.h 395936 
>   team/kmoore/event_system_strip/main/asterisk.c 395936 
>   team/kmoore/event_system_strip/main/cel.c 395936 
>   team/kmoore/event_system_strip/main/event.c 395936 
>   team/kmoore/event_system_strip/tests/test_cel.c 395936 
>   team/kmoore/event_system_strip/tests/test_event.c 395936 
> 
> Diff: https://reviewboard.asterisk.org/r/2732/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass for both CEL and what's left of the event system.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/b8d4c949/attachment.htm>