<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2732/">https://reviewboard.asterisk.org/r/2732/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2732/diff/2/?file=43502#file43502line333" style="color: black; font-weight: bold; text-decoration: underline;">team/kmoore/main/cel.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">333</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">AST_DECLARE_STRING_FIELDS</span><span class="p">(</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">334</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">AST_STRING_FIELD</span><span class="p">(</span><span class="n">name</span><span class="p">);</span><span class="tb"> </span><span class="cm">/*!< Name of this backend */</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">335</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stringfields are overkill here. 0 sized array it.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2732/diff/2/?file=43502#file43502line774" style="color: black; font-weight: bold; text-decoration: underline;">team/kmoore/main/cel.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int cel_report_event(struct ast_channel_snapshot *snapshot,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">764</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">ao2_callback</span><span class="p">(</span><span class="n">cel_backends</span><span class="p">,</span> <span class="n">OBJ_MULTIPLE</span> <span class="o">|</span> <span class="n">OBJ_NODATA</span><span class="p">,</span> <span class="n">cel_backend_send_cb</span><span class="p">,</span> <span class="n">ev</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just want to confirm that this runs in the same serialized fashion as the old code - I've read the code and think so, but confirmation is good.</pre>
</div>
<br />
<p>- Joshua</p>
<br />
<p>On August 1st, 2013, 12:28 p.m. UTC, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2013, 12:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This removes usage of the event system for CEL backend data distribution and strips unused pieces out of the event system.
This build on the work in https://reviewboard.asterisk.org/r/2703/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests still pass for both CEL and what's left of the event system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/kmoore/event_system_strip/cel/cel_custom.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/cel/cel_manager.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/cel/cel_odbc.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/cel/cel_pgsql.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/cel/cel_radius.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/cel/cel_sqlite3_custom.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/cel/cel_tds.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/include/asterisk/_private.h <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/include/asterisk/cel.h <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/include/asterisk/event.h <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/include/asterisk/event_defs.h <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/main/asterisk.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/main/cel.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/main/event.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/tests/test_cel.c <span style="color: grey">(395936)</span></li>
<li>team/kmoore/event_system_strip/tests/test_event.c <span style="color: grey">(395936)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2732/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>