[asterisk-dev] [Code Review] 2719: Move ast_str_container_alloc and friends to a better location
Joshua Colp
reviewboard at asterisk.org
Thu Aug 1 10:01:50 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2719/#review9281
-----------------------------------------------------------
Ship it!
Before putting this in *really* exercise stuff with different compile flags, etc, to ensure that you REALLY didn't break utils.
- Joshua Colp
On July 31, 2013, 2:23 p.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2719/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 2:23 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-22041
> https://issues.asterisk.org/jira/browse/ASTERISK-22041
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This moves ast_str_container_alloc, ast_str_container_add, ast_str_container_remove, and related private functions into strings.c/h since they really don't belong in astobj2.c/h.
>
>
> Diffs
> -----
>
> trunk/utils/Makefile 395852
> trunk/utils/refcounter.c 395852
> trunk/main/strings.c 395852
> trunk/include/asterisk/strings.h 395852
> trunk/main/astobj2.c 395852
> trunk/include/asterisk/astobj2.h 395852
>
> Diff: https://reviewboard.asterisk.org/r/2719/diff/
>
>
> Testing
> -------
>
> It compiles (even utils).
>
>
> Thanks,
>
> opticron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/5c9a3cc0/attachment.htm>
More information about the asterisk-dev
mailing list