[asterisk-dev] [Code Review] 2713: bridge features: Make Dial/Queue append their feature options rather than override existing ones.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2713/#review9280
-----------------------------------------------------------

Ship it!



/trunk/main/bridge_basic.c
<https://reviewboard.asterisk.org/r/2713/#comment18280>

    Traditionally anything not exposed shouldn't have an ast_ prefix.


- Joshua Colp


On July 29, 2013, 9:55 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2713/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 9:55 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and rmudgett.
> 
> 
> Bugs: ASTERISK-22209
>     https://issues.asterisk.org/jira/browse/ASTERISK-22209
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Prior to this patch, using CHANNEL(dtmf_features) to set features on a channel would be overridden when using certain applications that bridge calls. This patch fixes Dial and Queue so that they leave existing DTMF features already set on the channel's feature datastore in tact and simply append their requested features.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/bridge_basic.h 395701 
>   /trunk/main/bridge_basic.c 395701 
>   /trunk/main/features.c 395701 
> 
> Diff: https://reviewboard.asterisk.org/r/2713/diff/
> 
> 
> Testing
> -------
> 
> Predial handlers were used to append Transfer and Record features to both the caller and callee. Dial was used to call SIP/B with the parking feature enabled on the caller end only. This worked as anticipated with the caller having access to all three features while the callee had access to transfer and record features, but not parking.
> 
> A similar test was done against queues, but no predial handlers were used and instead the DTMF features were only set on the channel in the dialplan. But in general this worked the same way. Features applied with the queue application options were mixed with the existing features set with the CHANNEL(dtmf_features) function.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/41235e5d/attachment.htm>