[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8351
-----------------------------------------------------------



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16049>

    Red blob.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16050>

    Red blob.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16066>

    This isn't a valid configuration option for the endpoint config option.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16067>

    Idem.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16068>

    Idem.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16069>

    Idem.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16070>

    Idem.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16071>

    Idem.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16062>

    This doesn't seem right.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16051>

    Red blobs.



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16065>

    This isn't a valid configuration option for the contact config object.



team/group/pimp_my_sip/res/res_sip_acl.c
<https://reviewboard.asterisk.org/r/2471/#comment16052>

    Red blob.



team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c
<https://reviewboard.asterisk.org/r/2471/#comment16054>

    Red blob.



team/group/pimp_my_sip/res/res_sip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2471/#comment16055>

    Red blob.


This seems to be missing the outbound_auth configuration option for endpoints and the method configuration option for transports (looks like it got put in nat_hook).

- opticron


On April 24, 2013, 9:07 p.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:07 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/res/res_sip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_acl.c 386331 
>   team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_outbound_registration.c 386331 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/4ea99040/attachment-0001.htm>