[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8352
-----------------------------------------------------------


This is an awesome start, and documentation of SIP configuration options is something that is needed in a big way right now, so thanks a lot for this.

I didn't comment on much here since it's obvious that descriptions are minimal for the moment. However, I did try to make sure that descriptions that actually were present were also accurate.


team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16075>

    s/primay/primary/



team/group/pimp_my_sip/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16076>

    You don't actually have to configure a transport for an endpoint to be able to communicate. The transport just selects which of the configured transports to use when communicating with the endpoint. If you don't select one, then we'll just go with the first one that works.
    
    You do have to configure at least one transport section in res_sip.conf in order for Asterisk to actually be able to send and receive SIP traffic, but that is different from the transport option for endpoints.


- Mark Michelson


On April 25, 2013, 2:07 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 2:07 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/res/res_sip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_acl.c 386331 
>   team/group/pimp_my_sip/res/res_sip_endpoint_identifier_ip.c 386331 
>   team/group/pimp_my_sip/res/res_sip_outbound_registration.c 386331 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/808445d2/attachment.htm>