[asterisk-dev] [Code Review] MixMonitor: Document that MixMonitor requires AUDIOHOOK_INHERIT in order for transfers to preserve the MixMonitor

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2115/#review7094
-----------------------------------------------------------


I'm not sure this patch is meeting the intent of the comment I left on ASTERISK-18220.  The whole point is that reading the documentation for AUDIOHOOK_INHERIT would still leave most end users questioning what the appropriate scenarios are for its usage.

I think what I was expecting was to have an actual wiki page showing when you needed to use AUDIOHOOK_INHERIT, and when you don't - complete with dialplan examples showing its usage and how to set it up properly on the correct channel.

- Matt


On Sept. 17, 2012, 5:01 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2115/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 5:01 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This tendency is well documented in the AUDIOHOOK_INHERIT function already, but for some reason no mention was made of it within the MixMonitor application documentation itself. This patch adds a note mentioning this caveat and also provides some linkage to the AUDIOHOOK_INHERIT function which if I'm not mistaken should show up in the wiki shortly after this is committed.
> 
> 
> This addresses bug ASTERISK-18220.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18220
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_mixmonitor.c 373118 
> 
> Diff: https://reviewboard.asterisk.org/r/2115/diff
> 
> 
> Testing
> -------
> 
> For this patch, I mostly just checked that documentation was showing up properly within core show application.
> 
> I also did some verification that the behavior matched the description in AUDIOHOOK_INHERIT, but that was more for my own understanding than for the purpose of the patch.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120919/a53936fd/attachment.htm>