<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2115/">https://reviewboard.asterisk.org/r/2115/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure this patch is meeting the intent of the comment I left on ASTERISK-18220. The whole point is that reading the documentation for AUDIOHOOK_INHERIT would still leave most end users questioning what the appropriate scenarios are for its usage.
I think what I was expecting was to have an actual wiki page showing when you needed to use AUDIOHOOK_INHERIT, and when you don't - complete with dialplan examples showing its usage and how to set it up properly on the correct channel.</pre>
<br />
<p>- Matt</p>
<br />
<p>On September 17th, 2012, 5:01 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2012, 5:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This tendency is well documented in the AUDIOHOOK_INHERIT function already, but for some reason no mention was made of it within the MixMonitor application documentation itself. This patch adds a note mentioning this caveat and also provides some linkage to the AUDIOHOOK_INHERIT function which if I'm not mistaken should show up in the wiki shortly after this is committed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For this patch, I mostly just checked that documentation was showing up properly within core show application.
I also did some verification that the behavior matched the description in AUDIOHOOK_INHERIT, but that was more for my own understanding than for the purpose of the patch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18220">ASTERISK-18220</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/apps/app_mixmonitor.c <span style="color: grey">(373118)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2115/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>