[asterisk-dev] [Code Review]: Add IAX2 support for the new HANGUPCAUSE hash

[rmudgett]

> On May 24, 2012, 2:36 p.m., Mark Michelson wrote:
> > trunk/channels/chan_iax2.c, line 10144
> > <https://reviewboard.asterisk.org/r/1941/diff/2/?file=28225#file28225line10144>
> >
> >     I don't know the C standard too well, but is it guaranteed that the "true" value returned by a > operator is 1? Or can it be any non-zero value? This just feels risky.
> 
> opticron wrote:
>     Addressed.

The "true" value returned by comparisons and other logical operations is 1.  The C standard says so.  It is just not used that way very often.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1941/#review6316
-----------------------------------------------------------


On May 24, 2012, 3:34 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1941/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 3:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the IAX2 implementation of the "Who Hung Up?" work for Asterisk 11.  Numeric cause codes are provided for messages in which they're expected.  Additionally, methods of generating descriptions of frame types and subclasses have been exposed.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_iax2.c 367194 
>   trunk/include/asterisk/frame.h 367194 
>   trunk/main/frame.c 367194 
> 
> Diff: https://reviewboard.asterisk.org/r/1941/diff
> 
> 
> Testing
> -------
> 
> See tests in Review 1942.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/5269a8e8/attachment.htm>