[asterisk-dev] [Code Review]: Add IAX2 support for the new HANGUPCAUSE hash

[opticron]

> On May 24, 2012, 2:36 p.m., Mark Michelson wrote:
> > With the extra stuff you've added into frame.h, it may be worthwhile to update func_frametrace.c to use those helper functions. No need to do that in this review, but I thought I'd mention it just so it's somewhere outside of my brain.

I'll look into it after this goes in.


> On May 24, 2012, 2:36 p.m., Mark Michelson wrote:
> > trunk/channels/chan_iax2.c, line 10144
> > <https://reviewboard.asterisk.org/r/1941/diff/2/?file=28225#file28225line10144>
> >
> >     I don't know the C standard too well, but is it guaranteed that the "true" value returned by a > operator is 1? Or can it be any non-zero value? This just feels risky.

Addressed.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1941/#review6316
-----------------------------------------------------------


On May 22, 2012, 8:32 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1941/
> -----------------------------------------------------------
> 
> (Updated May 22, 2012, 8:32 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the IAX2 implementation of the "Who Hung Up?" work for Asterisk 11.  Numeric cause codes are provided for messages in which they're expected.  Additionally, methods of generating descriptions of frame types and subclasses have been exposed.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/main/frame.c 367194 
>   trunk/include/asterisk/frame.h 367194 
>   trunk/channels/chan_iax2.c 367194 
> 
> Diff: https://reviewboard.asterisk.org/r/1941/diff
> 
> 
> Testing
> -------
> 
> See tests in Review 1942.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/9bb90df5/attachment.htm>