[asterisk-dev] [Code Review]: Masquerade super test

[rmudgett]

> On May 24, 2012, 10:27 a.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/masquerade/run-test, lines 123-124
> > <https://reviewboard.asterisk.org/r/1930/diff/1/?file=28167#file28167line123>
> >
> >     May as well just remove these two lines.

I'll leave this in.  This may be needed for the agents to reduce load.


> On May 24, 2012, 10:27 a.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/masquerade/run-test, lines 176-178
> > <https://reviewboard.asterisk.org/r/1930/diff/1/?file=28167#file28167line176>
> >
> >     The test.start_asterisk() and test.stop_asterisk() lines are no longer necessary for tests.

Done.


> On May 24, 2012, 10:27 a.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/masquerade/configs/ast2/extensions.conf, lines 8-9
> > <https://reviewboard.asterisk.org/r/1930/diff/1/?file=28165#file28165line8>
> >
> >     Hm, it seems like there may be a remotely possible race condition here. It may be that '5432' is received in a way that the '54' is received on the back end of one Background call and then the '32' is received on the front end of the next one.
> >     
> >     The chances of this are insanely low, but it still is possible. Perhaps using WaitExten() with a huge wait time or Read() with a huge wait time would be better.

The demo-congrats file takes about 28 seconds to play.  However, it may take awhile for the local channels to optimize themselves out so the chance of the DTMF coming in during a restart is not that low.

Changing to use WaitExten.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1930/#review6301
-----------------------------------------------------------


On May 18, 2012, 3:27 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1930/
> -----------------------------------------------------------
> 
> (Updated May 18, 2012, 3:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The test creates a chain of local channels and then parks the call.
> When the local channels have optimized themselves out, the call is unparked to check the audio path.
> 
> Currently set for a chain of 300 local channels.
> 
> 
> This addresses bug ASTERISK-19807.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19807
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/masquerade/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast1/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast1/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/run-test PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 3230 
> 
> Diff: https://reviewboard.asterisk.org/r/1930/diff
> 
> 
> Testing
> -------
> 
> It's a test.  It passes itself. :)
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/978000cb/attachment-0001.htm>