[asterisk-dev] [Code Review] Masquerade super test

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1930/#review6301
-----------------------------------------------------------



/asterisk/trunk/tests/masquerade/configs/ast2/extensions.conf
<https://reviewboard.asterisk.org/r/1930/#comment11773>

    Hm, it seems like there may be a remotely possible race condition here. It may be that '5432' is received in a way that the '54' is received on the back end of one Background call and then the '32' is received on the front end of the next one.
    
    The chances of this are insanely low, but it still is possible. Perhaps using WaitExten() with a huge wait time or Read() with a huge wait time would be better.



/asterisk/trunk/tests/masquerade/run-test
<https://reviewboard.asterisk.org/r/1930/#comment11772>

    May as well just remove these two lines.



/asterisk/trunk/tests/masquerade/run-test
<https://reviewboard.asterisk.org/r/1930/#comment11771>

    The test.start_asterisk() and test.stop_asterisk() lines are no longer necessary for tests.


- Mark


On May 18, 2012, 3:27 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1930/
> -----------------------------------------------------------
> 
> (Updated May 18, 2012, 3:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The test creates a chain of local channels and then parks the call.
> When the local channels have optimized themselves out, the call is unparked to check the audio path.
> 
> Currently set for a chain of 300 local channels.
> 
> 
> This addresses bug ASTERISK-19807.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19807
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/masquerade/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast1/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast1/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/configs/ast2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/run-test PRE-CREATION 
>   /asterisk/trunk/tests/masquerade/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 3230 
> 
> Diff: https://reviewboard.asterisk.org/r/1930/diff
> 
> 
> Testing
> -------
> 
> It's a test.  It passes itself. :)
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/49c4af75/attachment-0001.htm>