[asterisk-dev] [Code Review]: Add original redirecting party support to REDIRECTING function.

[rmudgett]

> On March 24, 2012, 12:07 a.m., Alec Davis wrote:
> > /trunk/include/asterisk/channel.h, line 477
> > <https://reviewboard.asterisk.org/r/1829/diff/2/?file=26770#file26770line477>
> >
> >     nit picking 
> >     
> >     the previous 'since 1.8' doesn't apply. as this line would surely be 'since 11'

The structure has existed since 1.8.  Structure member changes have not usually been versioned nor have functions that have parameters added/removed been versioned like that.  The current usage of \since is to indicate when something was created/added to the codebase.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1829/#review5891
-----------------------------------------------------------


On March 23, 2012, 8:07 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1829/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 8:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ISDN ETSI PTP and Q.SIG (And soon SS7) have support for reporting who was the original redirecting party of a call.
> 
> Support for the original redirecting party is added to the REDIRECTING function and the system core as well as to the stubbed locations in sig_pri.c.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 360311 
>   /trunk/UPGRADE.txt 360311 
>   /trunk/channels/sig_pri.c 360311 
>   /trunk/funcs/func_callerid.c 360311 
>   /trunk/include/asterisk/channel.h 360311 
>   /trunk/main/channel.c 360311 
> 
> Diff: https://reviewboard.asterisk.org/r/1829/diff
> 
> 
> Testing
> -------
> 
> Outgoing ISDN calls made with the original redirecting party information set send the appropriate information.
> Incoming ISDN calls containing the original redirecting party information populate the REDIRECTING(orig) fields.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120327/767fb0e6/attachment.htm>