[asterisk-dev] [Code Review] chan_ooh323 direct rtp (remote bridging) support

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1607/#review5894
-----------------------------------------------------------

Ship it!


Reviewed one last time for some coding guideline issues and a few other issues.  Nice job!


/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1607/#comment10736>

    Per coding guidelines, comments should not include when something was changed.



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/1607/#comment10737>

    Since these are new configuration settings, CHANGES should be updated to reflect that these settings were added between Asterisk 10 and Asterisk 11.
    



/trunk/addons/ooh323c/src/ooCmdChannel.c
<https://reviewboard.asterisk.org/r/1607/#comment10738>

    You shouldn't need to check if paramx is NULL or not here.  If non-null, it was allocated (as you memset the structure to 0 when its first being created), and the malloc'd parameters should be free'd.
    
    Also, you may want to consider using ast_free here.



/trunk/addons/ooh323c/src/ooStackCmds.c
<https://reviewboard.asterisk.org/r/1607/#comment10740>

    Consider using ast_malloc.  You shouldn't need to cast these to void* either.



/trunk/addons/ooh323c/src/ooStackCmds.c
<https://reviewboard.asterisk.org/r/1607/#comment10739>

    Again, you shouldn't need to check the values of the parameters here before freeing them (and again, consider ast_free here)



/trunk/addons/ooh323c/src/ooStackCmds.c
<https://reviewboard.asterisk.org/r/1607/#comment10741>

    Again, consider using ast_free instead of free here.



/trunk/addons/ooh323c/src/ooh245.c
<https://reviewboard.asterisk.org/r/1607/#comment10742>

    This check should probably occur when request is first obtained - or at least before the memset of request, which could be a NULL pointer.


- Matt


On Jan. 6, 2012, 3:22 p.m., may213 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1607/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2012, 3:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There is direct rtp support for chan_ooh323 channel driver.
> It work like chan_sip direct rtp support based on directmedia (directrtp) option that can be global or per peer/user.
> Also there is earlydirect (directrtpsetup) option that allow setup direct rtp connection for early media.
> 
> On h.323 side there can be two modes to enable direct rtp - with or without renegotiation media channels.
> If there are opened media channels (logical channels in h.323) then renegotiation must be done and it caused by
> sending empty terminalcapabilities set to opposite side.  If empty tcs is arrived transmit logical channels
> will be closed then reopen with new rtp addresses.
> if there are no opened channels then new rtp addresses come in the new fast start proposal or just saved 
> for further use in the channel open negotiation (it is for fast start disabled case).
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/Makefile 349927 
>   /trunk/addons/chan_ooh323.h 349927 
>   /trunk/addons/chan_ooh323.c 349927 
>   /trunk/addons/ooh323c/src/ooCalls.h 349927 
>   /trunk/addons/ooh323c/src/ooCmdChannel.c 349927 
>   /trunk/addons/ooh323c/src/ooLogChan.h 349927 
>   /trunk/addons/ooh323c/src/ooLogChan.c 349927 
>   /trunk/addons/ooh323c/src/ooStackCmds.h 349927 
>   /trunk/addons/ooh323c/src/ooStackCmds.c 349927 
>   /trunk/addons/ooh323c/src/ooh245.h 349927 
>   /trunk/addons/ooh323c/src/ooh245.c 349927 
>   /trunk/addons/ooh323c/src/ooh323.c 349927 
>   /trunk/addons/ooh323c/src/ooh323ep.c 349927 
>   /trunk/addons/ooh323c/src/ooq931.h 349927 
>   /trunk/addons/ooh323c/src/ooq931.c 349927 
>   /trunk/addons/ooh323cDriver.c 349927 
>   /trunk/configs/chan_ooh323.conf.sample 349927 
>   /trunk/configs/ooh323.conf.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1607/diff
> 
> 
> Testing
> -------
> 
> h.323->h.323 (fast start enabled & disabled), h.323->sip, sip->h.323 remote bridging are tested and work well.
> Another rtp based channels (sccp, jingle) are not tested but must work.
> 
> 
> Thanks,
> 
> may213
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120326/045214dd/attachment-0001.htm>