[asterisk-dev] [Code Review] P-Asserted-Identity Privacy - fixed behaviour

[Bryant Zimmerman]

Does this patch allow for setting the remote identity to something other 
than the caller ID. our vendors want us to start setting remote identity 
when customers want to advertise their toll free numbers. This would allow 
us to use their local number on the Caller ID but have their toll free 
number as what would be displayed to the called party. Right now the 
current method seems to always override the remote identity with the Caller 
ID values. 

Thanks

Bryant  

----------------------------------------
 From: "Paul Belanger" <reviewboard at asterisk.org>
Sent: Tuesday, March 06, 2012 9:38 PM
To: "Paul Belanger" <reviewboard at asterisk.org>, ", "Asterisk Developers" 
<asterisk-dev at lists.digium.com>
Subject: Re: [asterisk-dev] [Code Review] P-Asserted-Identity Privacy - 
fixed behaviour

                                        This is an automatically generated 
e-mail. To reply, visit:             
https://reviewboard.asterisk.org/r/1803/             	          

Regardless of the patch, I'd also like to see a test for the testsuite.  
This seems like a good one to create a test for. 

- Paul 

On March 6th, 2012, 5:16 p.m., jamicque wrote: 
                                        Review request for Asterisk 
Developers.             By jamicque.             Updated March 6, 2012, 
5:16 p.m.             Description              
                                                                            
            It seams that in Asterisk privacy with PAI is not implemented 
correctly.  According to RFC 3325 when using privacy, FROM header should be 
set to anonymous at anonymous.invalid and PAI header should be set to caller 
num and name. The privacy is implemented by adding privacy: id header. Now 
when we use pai and callpres=prohib in P-Asserted-Identity header we have 
something which is not correct to any rfc. P-Asserted-Identity: "Anonymous" 
<sip:anonymous at anonymous.invalid>  What my patch does: 1) it adds Privacy 
header when PAI is used (values "none" or "id" depending on callpres) 2) 3) 
"sendrpid" configuration option have been expanded: now it can have those 
values:      no - nothing changed     yes - rpid header is added, when call 
PRES=prohi, FROM header is not changed     rpid - the same as yes     pai - 
pai header is added, when call PRES=prohi, FROM header is not changed  NEW 
VALUES:      rpid,trusted (NEW) - the same as yes     rpid,untrusted (NEW) 
- rpid header is added, when call PRES=prohi, FROM header is chenged to 
anonymous at anonymous.invalid     pai,trusted (NEW) - the same as pai     
pai,untrusted (NEW) - pai header is added, when call PRES=prohi, FROM 
header is chenged to anonymous at anonymous.invalid - as in RFC 3325           
               	                      

             Testing              
                                                                            
            I've done some basing test with outgoing calls and everything 
seems to wroks fine.                         	                      

                          Bugs:              ASTERISK-19465                 
         Diffs                               /trunk/channels/chan_sip.c 
(358434)                 /trunk/channels/sip/include/sip.h (358434)         
        /trunk/configs/sip.conf.sample (358434)                          

View Diff             	          


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120307/c2ce9372/attachment.htm>