<span style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt">Does this patch allow for setting the remote identity to something other than the caller ID. our vendors want us to start setting remote identity when customers want to advertise their toll free numbers. This would allow us to use their local number on the Caller ID but have their toll free number as what would be displayed to the called party. Right now the current method seems to always override the remote identity with the Caller ID values. <br />
<br />
<div>Thanks<br />
<br />
Bryant </div>
<br />
<br />
<span style="font-family: tahoma,arial,sans-serif; font-size: 10pt;"><hr width="100%" size="2" align="center">
</hr><b>From</b>: "Paul Belanger" <reviewboard@asterisk.org><br />
<b>Sent</b>: Tuesday, March 06, 2012 9:38 PM<br />
<b>To</b>: "Paul Belanger" <reviewboard@asterisk.org>, ", "Asterisk Developers" <asterisk-dev@lists.digium.com><br />
<b>Subject</b>: Re: [asterisk-dev] [Code Review] P-Asserted-Identity Privacy - fixed behaviour</span><br />
<br />
<div style="font-family: verdana, arial, helvetica, sans-serif;">
<table width="100%" style="border: 1px solid rgb(201, 195, 153); background-color: rgb(249, 243, 201);" cellpadding="8">
<tbody>
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1803/">https://reviewboard.asterisk.org/r/1803/</a>
</td>
</tr>
</tbody>
</table>
<br />
<pre style="white-space: pre-wrap; word-wrap: break-word;">Regardless of the patch, I'd also like to see a test for the testsuite. This seems like a good one to create a test for.</pre>
<br />
<p>- Paul</p>
<br />
<p>On March 6th, 2012, 5:16 p.m., jamicque wrote:</p>
<table width="100%" style="border: 1px solid black; background-image: url(https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png); background-repeat: repeat-x; background-color: rgb(254, 250, 223);" cellspacing="0" cellpadding="8">
<tbody>
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By jamicque.</div>
<p style="color: grey;"><i>Updated March 6, 2012, 5:16 p.m.</i></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" style="border: 1px solid rgb(184, 181, 160); background-color: rgb(255, 255, 255);" cellspacing="0" cellpadding="10">
<tbody>
<tr>
<td>
<pre style="margin: 0px; padding: 0px; white-space: pre-wrap; word-wrap: break-word;">It seams that in Asterisk privacy with PAI is not implemented correctly.
According to RFC 3325 when using privacy, FROM header should be set to anonymous@anonymous.invalid and PAI header should be set to caller num and name. The privacy is implemented by adding privacy: id header.
Now when we use pai and callpres=prohib in P-Asserted-Identity header we have something which is not correct to any rfc.
P-Asserted-Identity: "Anonymous" <sip:anonymous@anonymous.invalid>
What my patch does:
1) it adds Privacy header when PAI is used (values "none" or "id" depending on callpres)
2)
3) "sendrpid" configuration option have been expanded:
now it can have those values:
no - nothing changed
yes - rpid header is added, when call PRES=prohi, FROM header is not changed
rpid - the same as yes
pai - pai header is added, when call PRES=prohi, FROM header is not changed
NEW VALUES:
rpid,trusted (NEW) - the same as yes
rpid,untrusted (NEW) - rpid header is added, when call PRES=prohi, FROM header is chenged to anonymous@anonymous.invalid
pai,trusted (NEW) - the same as pai
pai,untrusted (NEW) - pai header is added, when call PRES=prohi, FROM header is chenged to anonymous@anonymous.invalid - as in RFC 3325
</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" style="border: 1px solid rgb(184, 181, 160); background-color: rgb(255, 255, 255);" cellspacing="0" cellpadding="10">
<tbody>
<tr>
<td>
<pre style="margin: 0px; padding: 0px; white-space: pre-wrap; word-wrap: break-word;">I've done some basing test with outgoing calls and everything seems to wroks fine.</pre>
</td>
</tr>
</tbody>
</table>
<div style="margin-top: 1.5em;">
<b style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19465">ASTERISK-19465</a>
</div>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Diffs </h1>
<ul style="padding-left: 0px; margin-left: 3em;">
<li>/trunk/channels/chan_sip.c <span style="color: grey;">(358434)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey;">(358434)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey;">(358434)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<br /></span>