[asterisk-dev] [Code Review] res_xmpp - A cleaned up drop-in replacement for res_jabber

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1983/#review6574
-----------------------------------------------------------

Ship it!


This looks good to me. Given the size of this, I'd feel better if there were at least another "Ship it" on this before committing though.


/trunk/res/res_xmpp.c
<https://reviewboard.asterisk.org/r/1983/#comment12469>

    Got yourself a red blob here (line 518)


- Mark


On June 21, 2012, 8:17 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1983/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 8:17 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a cleaned up drop-in replacement for res_jabber. It provides the same functionality but internally has different API calls. It also uses astobj2 for most things.
> 
> As things stand right now this is using the old configuration API but this will be migrated to the new one once some additional things have been added. Existing modules have *not* been converted over, but chan_jingle2 will be.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/cli_aliases.conf.sample 369033 
>   /trunk/include/asterisk/xmpp.h PRE-CREATION 
>   /trunk/res/res_xmpp.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1983/diff
> 
> 
> Testing
> -------
> 
> Tested client connections, component connections, authentication, roster adding/removing, all the options, pubsub, CLI commands, manager commands.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120626/c2363db9/attachment.htm>