[asterisk-dev] [Code Review] res_xmpp - A cleaned up drop-in replacement for res_jabber

Joshua Colp reviewboard at asterisk.org
Thu Jun 21 08:17:21 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1983/
-----------------------------------------------------------

(Updated June 21, 2012, 8:17 a.m.)


Review request for Asterisk Developers.


Changes
-------

Incorporated all the feedback from Mark, and also now uses the new configuration options API.


Summary
-------

This is a cleaned up drop-in replacement for res_jabber. It provides the same functionality but internally has different API calls. It also uses astobj2 for most things.

As things stand right now this is using the old configuration API but this will be migrated to the new one once some additional things have been added. Existing modules have *not* been converted over, but chan_jingle2 will be.


Diffs (updated)
-----

  /trunk/configs/cli_aliases.conf.sample 369033 
  /trunk/include/asterisk/xmpp.h PRE-CREATION 
  /trunk/res/res_xmpp.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/1983/diff


Testing
-------

Tested client connections, component connections, authentication, roster adding/removing, all the options, pubsub, CLI commands, manager commands.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/cdd6dad7/attachment.htm>


More information about the asterisk-dev mailing list