[asterisk-dev] [Code Review]: Add cause reporting to sig_ss7 for chan_dahdi

[opticron]

> On June 21, 2012, 3:48 p.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, lines 381-383
> > <https://reviewboard.asterisk.org/r/1955/diff/3/?file=29114#file29114line381>
> >
> >     Assumes that owner is locked.  This routine does not have enough information to correctly lock owner on its own.

This information is already there in the third "Assumes....", but I'll make it more clear.


> On June 21, 2012, 3:48 p.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, line 1301
> > <https://reviewboard.asterisk.org/r/1955/diff/3/?file=29114#file29114line1301>
> >
> >     I don't know how smart gcc is when assigning space for the cause[] and cause_str[] arrays since they could overlap.  You could just declare one char array at the top large enough for any reasonable string and not care about the smarts of gcc.

Done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1955/#review6544
-----------------------------------------------------------


On June 21, 2012, 3:32 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1955/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 3:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds HANGUPCAUSE hash reporting to the SS7 technology for chan_dahdi.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_ss7.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/1955/diff
> 
> 
> Testing
> -------
> 
> Tested with a SS7 link connected between two machines.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120622/1cab288b/attachment.htm>