[asterisk-dev] [Code Review] Add cause reporting to sig_ss7 for chan_dahdi

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1955/#review6544
-----------------------------------------------------------

Ship it!


Other than my minor comments below, this is good to go.


trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1955/#comment12360>

    Assumes that owner is locked.  This routine does not have enough information to correctly lock owner on its own.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1955/#comment12362>

    I don't know how smart gcc is when assigning space for the cause[] and cause_str[] arrays since they could overlap.  You could just declare one char array at the top large enough for any reasonable string and not care about the smarts of gcc.


- rmudgett


On June 21, 2012, 3:32 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1955/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 3:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds HANGUPCAUSE hash reporting to the SS7 technology for chan_dahdi.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_ss7.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/1955/diff
> 
> 
> Testing
> -------
> 
> Tested with a SS7 link connected between two machines.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/d78594f2/attachment.htm>