[asterisk-dev] [Code Review] Add "stun show status" command to the CLI

Matt Jordan reviewboard at asterisk.org
Thu Jun 21 14:26:14 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2001/#review6540
-----------------------------------------------------------


Also:

Please check the coding guidelines at https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines.  In particular, watch out for:

if( foo ) {
 ...
}else if( bar ) {
...
}

Per the guidelines referenced on the wiki page.  This should be:

if (foo) {
 ...
} else if (bar) {
 ...
}

- Matt


On June 21, 2012, 1:35 p.m., jkister wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2001/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 1:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add "stun show status" to the CLI
> 
> https://issues.asterisk.org/jira/browse/ASTERISK-18046
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stun_monitor.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/2001/diff
> 
> 
> Testing
> -------
> 
> stable for over 9 months. tested on 1.8, 10.4, 10.5
> 
> 
> Thanks,
> 
> jkister
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/db2ba3e2/attachment.htm>


More information about the asterisk-dev mailing list