[asterisk-dev] [Code Review] Add "stun show status" command to the CLI

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2001/#review6539
-----------------------------------------------------------



/trunk/res/res_stun_monitor.c
<https://reviewboard.asterisk.org/r/2001/#comment12341>

    If argc and argv aren't used, don't pass them to this function.



/trunk/res/res_stun_monitor.c
<https://reviewboard.asterisk.org/r/2001/#comment12339>

    These don't need to be compared against '1'.
    
    if (args.stun_poll_failed_gripe) {
    ...
    }



/trunk/res/res_stun_monitor.c
<https://reviewboard.asterisk.org/r/2001/#comment12340>

    Magic number - use a #define.



/trunk/res/res_stun_monitor.c
<https://reviewboard.asterisk.org/r/2001/#comment12343>

    This should check that a->argc != 3.  If that is the case, it should return CLI_SHOWUSAGE.


- Matt


On June 21, 2012, 1:35 p.m., jkister wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2001/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 1:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add "stun show status" to the CLI
> 
> https://issues.asterisk.org/jira/browse/ASTERISK-18046
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stun_monitor.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/2001/diff
> 
> 
> Testing
> -------
> 
> stable for over 9 months. tested on 1.8, 10.4, 10.5
> 
> 
> Thanks,
> 
> jkister
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/6267c9f6/attachment-0001.htm>