[asterisk-dev] [Code Review] use webrtc iILBC code for codec_iLBC

[Steve Underwood]

Hi,

Has anyone asked Google about this? The RFC contains a floating point 
implementation of iLBC. WebRTC contains a fixed point implementation of 
iLBC, and both fixed and floating point implementations of iSAC. Maybe 
they didn't include a floating point iLBC because they fell "its already 
out there". Google are extremely sloppy about copyright and patents, so 
its hard to tell without asking. They have been sloppy about the 
inclusion of test vectors in WebRTC, too. There are test programs that 
try to access test vectors they have not supplied.

Unless they've fixed it in the last few weeks, the iLBC code in WebRTC 
doesn't pass the test vectors when you set -O to anything greater than 
0. I haven't had time to track down the cause yet.

Regards,
Steve


On 06/05/2012 08:22 AM, Tzafrir Cohen wrote:
> This is an automatically generated e-mail. To reply, visit: 
> https://reviewboard.asterisk.org/r/1964/
>
>
> Review request for Asterisk Developers.
> By Tzafrir Cohen.
>
>
>   Description
>
> The license of the RFC3951 iLBC codec implementation does not seem clear to me and therefore I'm not sure I can use it.
>
> Google's implementation from webrtc.org is slightly different. Latly, however, someone has been working on adapting it for use with the interface provided by the RFC3951 implementation:
>
> http://github.com/dekkers/libilbc
>
> This patch uses that new libilbc to build codec_ilbc. As in the case of gsm, it's also possible to use the internal implementation, if one exists.
>
>
>   Testing
>
> Builds. A simple ilbc call works.
>
> *Bugs: * ASTERISK-19835 
> <https://issues.asterisk.org/jira/browse/ASTERISK-19835>
>
>
>   Diffs
>
>   * /trunk/build_tools/menuselect-deps.in (368514)
>   * /trunk/codecs/Makefile (368514)
>   * /trunk/codecs/codec_ilbc.c (368514)
>   * /trunk/configure (UNKNOWN)
>   * /trunk/configure.ac (368514)
>   * /trunk/makeopts.in (368514)
>
> View Diff <https://reviewboard.asterisk.org/r/1964/diff/>
>
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>     http://lists.digium.com/mailman/listinfo/asterisk-dev