[asterisk-dev] [Code Review] use webrtc iILBC code for codec_iLBC

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1964/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

The license of the RFC3951 iLBC codec implementation does not seem clear to me and therefore I'm not sure I can use it.

Google's implementation from webrtc.org is slightly different. Latly, however, someone has been working on adapting it for use with the interface provided by the RFC3951 implementation:

http://github.com/dekkers/libilbc

This patch uses that new libilbc to build codec_ilbc. As in the case of gsm, it's also possible to use the internal implementation, if one exists.


This addresses bug ASTERISK-19835.
    https://issues.asterisk.org/jira/browse/ASTERISK-19835


Diffs
-----

  /trunk/build_tools/menuselect-deps.in 368514 
  /trunk/codecs/Makefile 368514 
  /trunk/codecs/codec_ilbc.c 368514 
  /trunk/configure UNKNOWN 
  /trunk/configure.ac 368514 
  /trunk/makeopts.in 368514 

Diff: https://reviewboard.asterisk.org/r/1964/diff


Testing
-------

Builds. A simple ilbc call works.


Thanks,

Tzafrir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120605/3f54e2f1/attachment.htm>