[asterisk-dev] [Code Review] Revise skinny debugging messages

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2040/#review6705
-----------------------------------------------------------



trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2040/#comment12737>

    I'm actually curious why this is only available with --enable-dev-mode only?
    
    Something like 'sip set debug on' does not depend on this.



trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2040/#comment12734>

    invert logic



trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2040/#comment12735>

    if (!bitmask) continue?



trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2040/#comment12736>

    OMGBLOB


- Paul


On July 17, 2012, 6:04 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2040/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 6:04 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Rewrite of skinny debugging.
> 
> Debugging messages and associated controls only compiled in if configured with --enable-dev-mode
> 
> Debug messages provide more detail (including thread id) and are grouped so the user/dev can limit the type of messages displayed.
> 
> Functionally no real change to chan_skinny.
> 
> While the diff is fairly large, there are basically 3 components,
>  - definition of SKINNY_DEBUG at lines 134-152
>  - control functions at lines 3238-3374
>  - numerous uses of SKINNY_DEBUG throughout
> 
> 
> Diffs
> -----
> 
>   trunk/build_tools/cflags-devmode.xml 369904 
>   trunk/channels/chan_skinny.c 369904 
> 
> Diff: https://reviewboard.asterisk.org/r/2040/diff
> 
> 
> Testing
> -------
> 
> Been running for a while with --enable-dev-mode. Compiled and tested basic functionality without --enable-dev-mode.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/ebe93a9d/attachment.htm>