[asterisk-dev] [Code Review] Revise skinny debugging messages

[wedhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2040/
-----------------------------------------------------------

(Updated July 17, 2012, 6:04 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Refactored code as per opticron's suggestions. Also moved thread_id code into the macro.


Summary
-------

Rewrite of skinny debugging.

Debugging messages and associated controls only compiled in if configured with --enable-dev-mode

Debug messages provide more detail (including thread id) and are grouped so the user/dev can limit the type of messages displayed.

Functionally no real change to chan_skinny.

While the diff is fairly large, there are basically 3 components,
 - definition of SKINNY_DEBUG at lines 134-152
 - control functions at lines 3238-3374
 - numerous uses of SKINNY_DEBUG throughout


Diffs (updated)
-----

  trunk/build_tools/cflags-devmode.xml 369904 
  trunk/channels/chan_skinny.c 369904 

Diff: https://reviewboard.asterisk.org/r/2040/diff


Testing
-------

Been running for a while with --enable-dev-mode. Compiled and tested basic functionality without --enable-dev-mode.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/32ffa9b0/attachment-0001.htm>