[asterisk-dev] [Code Review] TestSuite archiving of Asterisk logs on test run failure

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1431/#review4336
-----------------------------------------------------------

Ship it!


Looks good


/asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/1431/#comment8427>

    Too bad we don't expose, or track, the number of instance IDs a test will use. That would be cleaner then iterating over all ast%d sub directories found.


- Paul


On Sept. 13, 2011, 11:01 a.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1431/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 11:01 a.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> The TestSuite will now archive the Asterisk logs if a test run fails.  All logs are copied to the local ./logs directory, using the same relative test path used for the /tmp/asterisk-testsuite/ directory.
> 
> Note that since the top level script does not have knowledge of the number of instances of Asterisk created by a test, all Asterisk (ast1, etc.) directories created by the test are archived.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 2188 
>   /asterisk/trunk/runtests.py 2190 
> 
> Diff: https://reviewboard.asterisk.org/r/1431/diff
> 
> 
> Testing
> -------
> 
> local machine.  Induced a test failure, tested multiple runs to ensure that archiving occurs even if directories were previously copied.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110914/2df46db0/attachment.htm>