[asterisk-dev] [Code Review] TestSuite archiving of Asterisk logs on test run failure

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1431/
-----------------------------------------------------------

(Updated Sept. 13, 2011, 11:01 a.m.)


Review request for Asterisk Developers and Paul Belanger.


Changes
-------

Based on some discussion with pabelanger and kpfleming, the test will now attempt to hard link to the Asterisk logs in /tmp/asterisk-testsuite/.  If the hard link fails (which will occur if /tmp/asterisk-testsuite/ is on a different file system partition then the directory executing the test), then the files will be copied.  It will be up to the test systems to manage the Asterisk logs in /tmp/asterisk-testsuite/ and the hard link in ./logs/ if the hard link succeeds.


Summary
-------

The TestSuite will now archive the Asterisk logs if a test run fails.  All logs are copied to the local ./logs directory, using the same relative test path used for the /tmp/asterisk-testsuite/ directory.

Note that since the top level script does not have knowledge of the number of instances of Asterisk created by a test, all Asterisk (ast1, etc.) directories created by the test are archived.


Diffs (updated)
-----

  /asterisk/trunk/lib/python/asterisk/asterisk.py 2188 
  /asterisk/trunk/runtests.py 2190 

Diff: https://reviewboard.asterisk.org/r/1431/diff


Testing
-------

local machine.  Induced a test failure, tested multiple runs to ensure that archiving occurs even if directories were previously copied.


Thanks,

mjordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/bd267fe4/attachment.htm>