[asterisk-dev] [Code Review] Clean up dsp.conf parsing

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1434/#review4317
-----------------------------------------------------------

Ship it!


Rock on.

- wdoekes


On Sept. 13, 2011, 10:54 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1434/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 10:54 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch involves more actual code changes then the previous and brings dsp.conf inline with how the previous modules are parsed.  Also include code formatting cleanups.
> 
> Basically:
> - check if config is unchanged; if yes return
> - setup defaults
> - check if config is missing or invalid, if yes return
> - parse values
> 
> 
> Diffs
> -----
> 
>   trunk/main/dsp.c 335557 
> 
> Diff: https://reviewboard.asterisk.org/r/1434/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/29b199e7/attachment.htm>