[asterisk-dev] [Code Review] Clean up dsp.conf parsing

Paul Belanger reviewboard at asterisk.org
Tue Sep 13 10:54:46 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1434/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch involves more actual code changes then the previous and brings dsp.conf inline with how the previous modules are parsed.  Also include code formatting cleanups.

Basically:
- check if config is unchanged; if yes return
- setup defaults
- check if config is missing or invalid, if yes return
- parse values


Diffs
-----

  trunk/main/dsp.c 335557 

Diff: https://reviewboard.asterisk.org/r/1434/diff


Testing
-------

local development box


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/96a85f84/attachment.htm>


More information about the asterisk-dev mailing list