[asterisk-dev] [Code Review] Fix *8 directed pickup locks system while sucessful pickupsound plays out.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1232/
-----------------------------------------------------------

Review request for Asterisk Developers and rmudgett.


Summary
-------

https://reviewboard.asterisk.org/r/1185/ finished off with the target channel requiring to be locked for the duration of the pickupsound, otherwise there was a clash between 2 threads trying to write data.

This simple change keeps the playout of the sucessful pickupsound in the same thread as the bridge, now played out by bridge_play_sounds().


This addresses bug 18654.
    https://issues.asterisk.org/view.php?id=18654


Diffs
-----

  trunk/main/features.c 320797 

Diff: https://reviewboard.asterisk.org/r/1232/diff


Testing
-------

yes, simple pickups with SIP and DAHDI, but to exaggerate the issue for testing purposes set pickupsound=tt_monkeys set in features.conf, and checking with 'core show locks' that no locks exist during playout. They do prior to this change.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110526/5151d2c4/attachment.htm>