[asterisk-dev] [Code Review] Adjust formats of chan_local when channel we proxying changes

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1137/
-----------------------------------------------------------

(Updated 2011-05-25 08:22:36.656315)


Review request for Asterisk Developers.


Changes
-------

here is a patch with little more lock sanity should bridge be locked / reffed ??
should there be some deadlock avoidance when locking p->chan wrt ast ??


Summary
-------

This is a most annoying pain and tripped me up no end testing the T38 gateway patch for res_fax.

Scenario :-

i have a Linksys 2102 on a fax machine that uses G.729 and switches to ALAW on CNG and then negotiates T.38
this is awesome as i can now Chat/Fax from same terminal using most effective bandwidth [these are to be deployed
on sugar cane farms surrounding the kruger park here in south africa over wi-fi]

for testing purposes im using a local channel into T.30 fax app in res_fax.

Problem :-

when the device reinvites ALAW then T.38 it leaves the nativeformat on chan_local as G.729 this will not work
as it is transcoding the FAX from G.729 to SLIN this will not work and took me a while to spot the problem.

Soloution :-

Check the format on the proxy and adjust it if it changes this should be what Local does been a proxy of the channel
it should follow changes ...


Diffs (updated)
-----

  /trunk/channels/chan_local.c 320770 

Diff: https://reviewboard.asterisk.org/r/1137/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110525/84ba2e2b/attachment.htm>