[asterisk-dev] [Code Review] Adjust formats of chan_local when channel we proxying changes

[irroot]

> On 2011-05-24 09:53:32, David Vossel wrote:
> > /trunk/channels/chan_local.c, lines 528-544
> > <https://reviewboard.asterisk.org/r/1137/diff/3/?file=16494#file16494line528>
> >
> >     The bridge channel will be locked in the set format functions... This will result in a deadlock if the bridge channel is not safely locked before entering those functions.

ah but its not as simple as that ... we not changing the format on bridge here bridge is the "real" channel ->owner / ->chan are the local proxy now if i reorder this code ill only have to worry about ->chan been locked to set the formats.

patch will be coming up shortly ...


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1137/#review3603
-----------------------------------------------------------


On 2011-05-13 00:17:57, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1137/
> -----------------------------------------------------------
> 
> (Updated 2011-05-13 00:17:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a most annoying pain and tripped me up no end testing the T38 gateway patch for res_fax.
> 
> Scenario :-
> 
> i have a Linksys 2102 on a fax machine that uses G.729 and switches to ALAW on CNG and then negotiates T.38
> this is awesome as i can now Chat/Fax from same terminal using most effective bandwidth [these are to be deployed
> on sugar cane farms surrounding the kruger park here in south africa over wi-fi]
> 
> for testing purposes im using a local channel into T.30 fax app in res_fax.
> 
> Problem :-
> 
> when the device reinvites ALAW then T.38 it leaves the nativeformat on chan_local as G.729 this will not work
> as it is transcoding the FAX from G.729 to SLIN this will not work and took me a while to spot the problem.
> 
> Soloution :-
> 
> Check the format on the proxy and adjust it if it changes this should be what Local does been a proxy of the channel
> it should follow changes ...
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 318143 
> 
> Diff: https://reviewboard.asterisk.org/r/1137/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110525/563b380d/attachment-0001.htm>