[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-22 17:03:07.836617)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.


Changes
-------

Updated patch to remove the changes that have been submited to chan_sip this is the "pure" gateway framehook.

the detach framehook routine can be used to disengage the framehook on a T.30/T.38/Audio call the Audio call will be
more tricky and would require a timer to be set that if CED/T.38 is not detected/engaged in X seconds it must be removed.

ill add T.30/T38 disengage in soon ...

the framehook should perhaps only be used when CNG is detected in the fax extension this is upto the dialplan implementer and could be added to the documentation / release as a guideline.


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405, 19215 and 19251.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215
    https://issues.asterisk.org/view.php?id=19251


Diffs (updated)
-----

  /team/irroot/t38gateway-trunk/CHANGES 318975 
  /team/irroot/t38gateway-trunk/include/asterisk/res_fax.h 318975 
  /team/irroot/t38gateway-trunk/res/res_fax.c 318975 
  /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c 318975 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110522/114b04bb/attachment.htm>