[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3582
-----------------------------------------------------------


The T.38 negotiation code appears to properly only start the gateway if the two channels are incompatible, although it does not appear to remove the frame hook once the two channels have successfully negotiated T.38 between each other.  I don't think that is a major problem.

I still need to look at the code some more and evaluate every possible scenario but so far it looks good.

- Matthew


On 2011-05-16 04:45:08, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-05-16 04:45:08)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405, 19215 and 19251.
>     https://issues.asterisk.org/view.php?id=13405
>     https://issues.asterisk.org/view.php?id=19215
>     https://issues.asterisk.org/view.php?id=19251
> 
> 
> Diffs
> -----
> 
>   /team/irroot/t38gateway-trunk/CHANGES 318975 
>   /team/irroot/t38gateway-trunk/channels/chan_sip.c 318975 
>   /team/irroot/t38gateway-trunk/channels/sip/include/sip.h 318975 
>   /team/irroot/t38gateway-trunk/include/asterisk/res_fax.h 318975 
>   /team/irroot/t38gateway-trunk/res/res_fax.c 318975 
>   /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c 318975 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110519/0b9d5bbe/attachment.htm>