[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3529
-----------------------------------------------------------


I found a few minor issues that I have outlined below.  I am still reviewing the negotiation code, expect comments on that code tomorrow.


/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7214>

    Where is this destroy_callback() function defined? I don't see it in this patch.



/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7213>

    This function doesn't actually return the gateway datastore, perhaps it should be called find_session_gateway().



/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7211>

    We need to add a ref for gateway here (as the comment says).



/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7212>

    We don't need to ref gateway here if we allocated it on this function call.  Only ref if we are returning a reference we got form the datastore.



/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7208>

    The gateway should be removed from the channel here and shut down if it is running.


- Matthew


On 2011-05-11 01:53:10, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-05-11 01:53:10)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405, 19215 and 19251.
>     https://issues.asterisk.org/view.php?id=13405
>     https://issues.asterisk.org/view.php?id=19215
>     https://issues.asterisk.org/view.php?id=19251
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 318143 
>   /trunk/channels/sip/include/sip.h 318143 
>   /trunk/include/asterisk/res_fax.h 318143 
>   /trunk/res/res_fax.c 318143 
>   /trunk/res/res_fax_spandsp.c 318143 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110511/1c4ec5d8/attachment-0001.htm>