[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-11 01:53:10.521423)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

1)Merged "faxdetect" app into res_fax and renamed it WaitFax to more appropriately indicate what it does
wait for a faxtone upto X seconds this is used to trigger a divert to fax before dial is called or for dialplan
handling of faxtone in my app i call it "Early fax detect" this allows more flexibility when working with faxdetect
traditionally i used the Wait app ... 

2)only change media formats when the session is allocated [gateway mode] this may not be correct or should be optional ??
if the channel is not A/U LAW SLIN CED detection will not take place if i set the audio formats to SLIN early i can "MAYBE"
detect this tone.
if the device is narrowband the device [ATA/....] should then do the CED detect as in the case of Linksys ATA im using with G729
when a fax is sent on the G729 it handles the CED / T38 switch on the TDM so how nice are we trying to pick up CED GSM/G726 should work ok.

3)unlink the session from faxregistry.container oops my bad ...

4)Stupid error that crept in from the 1.8 branch .... yes i have written out 1000 times build and test before posting ....

Greg


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405, 19215 and 19251.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215
    https://issues.asterisk.org/view.php?id=19251


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 318143 
  /trunk/channels/sip/include/sip.h 318143 
  /trunk/include/asterisk/res_fax.h 318143 
  /trunk/res/res_fax.c 318143 
  /trunk/res/res_fax_spandsp.c 318143 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110511/95f75fd6/attachment.htm>