[asterisk-dev] [Code Review] chan_sip: cleanup from the introduction of ast_str

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1281/#review3789
-----------------------------------------------------------

Ship it!


Great work! 

- David


On 2011-06-23 15:18:01, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1281/
> -----------------------------------------------------------
> 
> (Updated 2011-06-23 15:18:01)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Remove the length field from sip_req and sip_pkt in chan_sip since they are redundant (ast_str holds its own length) and refactor the necessary functions.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 324709 
>   trunk/channels/sip/include/sip.h 324709 
> 
> Diff: https://reviewboard.asterisk.org/r/1281/diff
> 
> 
> Testing
> -------
> 
> Ran the PROTOS sip test suite against it.  Did some basic call tests.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110629/e9b6336e/attachment.htm>