[asterisk-dev] [Code Review] Segfault on shutdown when confbridge is active

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1283/#review3777
-----------------------------------------------------------



trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1283/#comment7576>

    What would happen if you just made a check for ast_shutting_down right after leaving the conference and exited immediately on shutdown.  I mean we really don't have to worry about doing anything except exiting cleanly if we are shutting down anyway.
    
    if (ast_shutting_down()) {
        goto confbridge_cleanup;
    }


- David


On 2011-06-24 14:17:54, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1283/
> -----------------------------------------------------------
> 
> (Updated 2011-06-24 14:17:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When undergoing a shutdown and channels are kicked out of a bridge, a segfault occurs because ConfBridge tries to play sounds on the bridge after the underlying channels have been blown away due to the shutdown.  This patch prevents ConfBridge from playing any additional sounds if Asterisk is shutting down.
> 
> 
> This addresses bug ASTERISK-18040.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18040
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 324709 
> 
> Diff: https://reviewboard.asterisk.org/r/1283/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110624/b2a7cf98/attachment.htm>