[asterisk-dev] [Code Review] Replace Berkeley DB astdb with SQLite3

[Terry Wilson]

> On 2011-06-14 00:23:50, Tzafrir Cohen wrote:
> > /trunk/main/Makefile, line 37
> > <https://reviewboard.asterisk.org/r/1269/diff/1/?file=16881#file16881line37>
> >
> >     Any need for AST_CFLAGS anywhere? (if a copy of sqlite in a non-standard location is used to build Asterisk)?
> 
> Terry Wilson wrote:
>     I'm pretty sure that if --with-sqlite3 is passed, all of that gets taken care of for us.
> 
> Russell Bryant wrote:
>     I don't think so.  I believe you need to using the SQLITE3_CFLAGS variable somewhere in the main Makefile.  Any CFLAGS in that variable need to be used when building db.c.  It may be just something like this in main/Makefile:
>     
>     db.o: ASTCFLAGS+=$(SQLITE3_CFLAGS)
> 
> Terry Wilson wrote:
>     Ah. Live and learn. Changed in the branch.
> 
> Russell Bryant wrote:
>     Cool.  Make sure you test it out though and make sure it works.  My comment was from memory and untested.  :-)

I tested. :-)


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1269/#review3714
-----------------------------------------------------------


On 2011-06-14 11:26:02, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1269/
> -----------------------------------------------------------
> 
> (Updated 2011-06-14 11:26:02)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There have been a couple of bugs reported lately against the Berkeley DB version that Asterisk uses for its internal database. These bugs have been tracked to the actual Berkeley code Asterisk uses, which is very very old and unmaintained. This patch replaces the Berkeley code with SQLite3 while maintaining exactly the same API. If there is no sqlite3 version of the database already and there is a Berkeley DB version, it automatically converts the old database to the new format.
> 
> If this goes in, I would then like to update Olle's patch for Realtime support for astdb as well and get that in.
> 
> 
> Diffs
> -----
> 
>   /configure UNKNOWN 
>   /trunk/configure.ac 323369 
>   /trunk/main/Makefile 323369 
>   /trunk/main/db.c 323369 
>   /trunk/tests/test_db.c 323369 
> 
> Diff: https://reviewboard.asterisk.org/r/1269/diff
> 
> 
> Testing
> -------
> 
> All astdb tests pass and I have tested converting several astdb databases.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110614/0ea53704/attachment.htm>